tls: persist generated TLS cert/key pair (PROJQUAY-1838) #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecmerdler
force-pushed
the
PROJQUAY-1838
branch
3 times, most recently
from
cb3a0c0 to
f28e47d
Compare
alecmerdler
commented
May 5, 2021
| - name: configvolume | ||
| secret: | ||
| secretName: quay-config-secret | ||
| - name: config |
There was a problem hiding this comment.
Switch to use k8s projected volume to mount both Secretscontaining config bundle and TLS cert/key into the same /conf/stack directory in the container.
alecmerdler
force-pushed
the
PROJQUAY-1838
branch
3 times, most recently
from
7f6050c to
9507d22
Compare
Move the 'ssl.cert' and 'ssl.key' to a separate, persistent Secret to ensure that the cert/key pair is not re-generated on every reconcile. Use k8s projected volumes to mount the config and TLS Secrets to the same directory in the Quay container. Signed-off-by: Alec Merdler <[email protected]>
alecmerdler
commented
May 14, 2021
| @@ -192,9 +237,9 @@ func (r *QuayRegistryReconciler) checkObjectBucketClaimsAvailable(ctx *quayconte | |||
| } | |||
|
|
|||
| // TODO: Improve this once `builds` is a managed component. | |||
| func (r *QuayRegistryReconciler) checkBuildManagerAvailable(ctx *quaycontext.QuayRegistryContext, quay *v1.QuayRegistry, rawConfig []byte) (*quaycontext.QuayRegistryContext, *v1.QuayRegistry, error) { | |||
| func (r *QuayRegistryReconciler) checkBuildManagerAvailable(ctx *quaycontext.QuayRegistryContext, quay *v1.QuayRegistry, configBundle map[string][]byte) (*quaycontext.QuayRegistryContext, *v1.QuayRegistry, error) { | |||
There was a problem hiding this comment.
Refactored all the "feature detection" functions to accept the full config bundle so that we can check ssl.cert/ssl.key, not just config.yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the 'ssl.cert' and 'ssl.key' to a separate, persistent
Secret to ensure that the cert/key pair is not re-generated
on every reconcile. Use k8s projected volumes to mount the
config and TLS Secrets to the same directory in the Quay
container.
Signed-off-by: Alec Merdler [email protected]