PROJQUAY-1157 - set default storage name to RHOCS #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtismullins
suggested changes
Oct 30, 2020
There was a problem hiding this comment.
It looks like Rados is specified elsewhere as well:
(quay-py3) [kmullins@rh-laptop quay-operator]$ grep -i "rados" -r * --include=\*.go --include=\*.yaml
apis/redhatcop/v1alpha1/quayecosystem_types.go: RADOS *RADOSRegistryBackendSource `json:"rados,omitempty,name=rados"`
apis/redhatcop/v1alpha1/quayecosystem_types.go:// RADOSRegistryBackendSource defines Ceph RADOS registry storage
apis/redhatcop/v1alpha1/quayecosystem_types.go:type RADOSRegistryBackendSource struct {
apis/redhatcop/v1alpha1/zz_generated.deepcopy.go:func (in *RADOSRegistryBackendSource) DeepCopyInto(out *RADOSRegistryBackendSource) {
apis/redhatcop/v1alpha1/zz_generated.deepcopy.go:// DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new RADOSRegistryBackendSource.
apis/redhatcop/v1alpha1/zz_generated.deepcopy.go:func (in *RADOSRegistryBackendSource) DeepCopy() *RADOSRegistryBackendSource {
apis/redhatcop/v1alpha1/zz_generated.deepcopy.go: out := new(RADOSRegistryBackendSource)
apis/redhatcop/v1alpha1/zz_generated.deepcopy.go: if in.RADOS != nil {
apis/redhatcop/v1alpha1/zz_generated.deepcopy.go: in, out := &in.RADOS, &out.RADOS
apis/redhatcop/v1alpha1/zz_generated.deepcopy.go: *out = new(RADOSRegistryBackendSource)
config/crd/bases/redhatcop.redhat.io.quay.redhat.com_quayecosystems.yaml: rados:
config/crd/bases/redhatcop.redhat.io.quay.redhat.com_quayecosystems.yaml: description: RADOSRegistryBackendSource defines Ceph RADOS
deploy/manifests/quay-operator/3.4.0/quayecosystems.redhatcop.redhat.io.crd.yaml: rados:
deploy/manifests/quay-operator/3.4.0/quayecosystems.redhatcop.redhat.io.crd.yaml: description: RADOSRegistryBackendSource defines Ceph RADOS
deploy/manifests/quay-operator/0.0.1/quayecosystems.redhatcop.redhat.io.crd.yaml: rados:
deploy/manifests/quay-operator/0.0.1/quayecosystems.redhatcop.redhat.io.crd.yaml: description: RADOSRegistryBackendSource defines Ceph RADOS
pkg/kustomize/secrets.go: Name: "RadosGWStorage",
pkg/kustomize/secrets_test.go: Name: "RadosGWStorage",
kurtismullins
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/PROJQUAY-1157
Changelog:
none
Docs:
none
Testing:
Confirm config.yaml contains reference to RHOCS instead of RADOS
Details:
Change string reference to proper storage