Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set External TLS Termination Field Correctly (PROJQUAY-1091) #320

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Set External TLS Termination Field Correctly (PROJQUAY-1091) #320

merged 1 commit into from
Sep 22, 2020

Conversation

alecmerdler
Copy link
Contributor

Issue: https://issues.redhat.com/browse/PROJQUAY-1091

Changelog: Ensure EXTERNAL_TLS_TERMINATION field based on inclusion of custom SERVER_HOSTNAME.

Docs: N/a

Testing: Create a zero-config QuayRegistry and ensure that EXTERNAL_TLS_TERMINATION: true.

Details: Previously we always set EXTERNAL_TLS_TERMINATION to false, but we need to set it to true when using the zero-config Route.

@alecmerdler alecmerdler merged commit 9a3bb2d into quay:master Sep 22, 2020
@alecmerdler alecmerdler deleted the PROJQUAY-1091 branch September 22, 2020 18:39
@alecmerdler alecmerdler mentioned this pull request Sep 25, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alecmerdler