Components API #280
Merged
Components API #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes API to use
spec.componentsversusspec.managedComponents. This field allows you to specify the component name, and whether its lifecycle is managed externally or by the Operator.This API has a UX advantage of being able to create a full batteries-included install of Quay without specifying each individual component. If an upgrade to the Operator adds a new component, it will be enabled by default without the user needing to modify the
QuayRegistryinstance. Making components unmanaged is as simple as changingmanaged: false.The Operator will populate
spec.componentswith any components not specified on create/update, defaulting tomanaged: true. This gives the user visibility into what components are being deployed.The new API looks like this:
Testing
Unit tests:
$ go test -v ./...Screenshots
Create
QuayRegistryUI form (driven byspecDescriptorand OpenAPI):Needed for https://issues.redhat.com/browse/PROJQUAY-827