Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions #129

Merged
merged 2 commits into from
Jan 20, 2020
Merged

GitHub Actions #129

merged 2 commits into from
Jan 20, 2020

Conversation

sabre1041
Copy link
Contributor

Migration from Travis to GitHub actions to resolve #126

cnuland
cnuland approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@cnuland cnuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will create an issue to add the E2E tests to the CI process

kurtismullins
kurtismullins approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@kurtismullins kurtismullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment. Otherwise, LGTM.

Makefile
# Travis Latest Tag Deployment
travis-latest-deploy: docker-login docker-build docker-push
# CI Latest Tag Deployment
ci-latest-deploy: docker-login docker-build docker-push
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabre1041 Should this PR go ahead and remove the .travis.yml file as well since these make targets will no longer be available to it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurtismullins I updated the PR to include travis and correct a few things. I havent had a chance to test the tag path fully, but since we arent planning a tag in the immediate, I'd like to get this out there

kurtismullins
kurtismullins approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@kurtismullins kurtismullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kurtismullins kurtismullins merged commit 40202f5 into quay:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtismullins kurtismullins kurtismullins approved these changes

@cnuland cnuland cnuland approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Migration from Travis to GitHub Actions
3 participants
@sabre1041 @kurtismullins @cnuland