Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project creation tests failing in Node 18.19 #16701

Closed
rotu opened this issue Dec 14, 2023 · 2 comments
Closed

Project creation tests failing in Node 18.19 #16701

rotu opened this issue Dec 14, 2023 · 2 comments
Labels
area/project-creation Related to project creation process using the commands: `yarn create quasar` and `npm init quasar` bug/1-hard-to-reproduce A reproduction is available, but it's hard to reproduce, so it has a lower priority. bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@rotu
Copy link
Contributor

rotu commented Dec 14, 2023

What happened?

Project creation tests are failing in CI.

What did you expect to happen?

I expect project creation tests to pass in CI

Reproduction URL

https://github.com/quasarframework/quasar/actions/runs/7201703422/job/19618401053

How to reproduce?

Run CI.

Flavour

Quasar CLI with Vite (@quasar/cli | @quasar/app-vite)

Areas

Project Creation (create-quasar)

Platforms/Browsers

No response

Quasar info output

No response

Relevant log output

No response

Additional context

Discovered when doing #6699

This seems to be caused by an unfortunate interaction between Node and tsx.

see:

Note that bumping tsx to version 4 would break compatibility with Node 18.
@rotu rotu added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels Dec 14, 2023
@github-actions github-actions bot added area/project-creation Related to project creation process using the commands: `yarn create quasar` and `npm init quasar` bug/1-hard-to-reproduce A reproduction is available, but it's hard to reproduce, so it has a lower priority. bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite labels Dec 14, 2023
@u5r0 u5r0 mentioned this issue Dec 18, 2023
Closed
@rotu
Copy link
Contributor Author

rotu commented Dec 20, 2023

The "obvious" fix is to bump tsx (#16719) but this is incompatible with Node 16 (which is out of support). Recommend to change the minimum Node version to 18 and the default to 20 (#16714).

Thoughts, @rstoenescu?

@yusufkandemir
Copy link
Member

Thanks for reporting. This was fixed in e6b161c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/project-creation Related to project creation process using the commands: `yarn create quasar` and `npm init quasar` bug/1-hard-to-reproduce A reproduction is available, but it's hard to reproduce, so it has a lower priority. bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rotu @yusufkandemir