Fix primitive class handling in Serialisers #37788
Conversation
geoand
commented
Dec 16, 2023
•
geoand
commented
- Fixes: #Rest client does not support other primitive response types when filter like OIDC client filter is used after optimization of primitive checks #37776
|
🙏 |
| @@ -18,7 +18,7 @@ public class ResponseInfoResource { | |||
|
|
|||
| @Path("/simple") | |||
| @GET | |||
| public String get(@QueryParam("abs") String abs) { | |||
| public boolean get(@QueryParam("abs") String abs) { | |||
There was a problem hiding this comment.
Should we add a test instead of changing an existing one?
Or this is safe?
There was a problem hiding this comment.
It's totally safe because the response itself was not being used anywhere and now it is.
I also checked that with this test the previous version of the code was failing
|
@geoand please check if there was some useless private empty method which was used in the Serialisers https://github.com/quarkusio/quarkus/pull/37778/files#diff-4331c4565452796771e5f021cc452593f1cbb4ee69557f63868aae37641769c6L263 |
|
There don't seem to be any |
|
I am surprised...the diff I have posted was with my change that was removing that dangerous used empty method (and replacing the usages with the right one)...where is gone? ... minutes later ... Found it! So it should be declared there and replaced with the one you have added If we had no failures despite it we are lacking some tests |
This comment has been minimized.
This comment has been minimized.
|
@franz1981 thanks! Fixed |
|
Would it be possible to get it in, please? |
ah, I didn't mention of this, okay let's wait, just annoying to have CI failures |
|
Yeah, let's wait for a review from @gsmet |
|
Sorry for the delay! |
|
🙏 |
