Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude commons-logging in quarkus bom #33405

Merged
merged 1 commit into from
May 17, 2023
Merged

Exclude commons-logging in quarkus bom #33405

merged 1 commit into from
May 17, 2023

Conversation

scrocquesel
Copy link
Contributor

Following investigation on #33354

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label May 16, 2023
@scrocquesel
Copy link
Contributor Author

/review @gsmet

@scrocquesel scrocquesel mentioned this pull request May 16, 2023
Merged
@gsmet gsmet requested a review from aloubyansky May 16, 2023 11:11
@quarkus-bot
Copy link

quarkus-bot bot commented May 16, 2023

Failing Jobs - Building 0b95e00

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18
✔️ Maven Tests - JDK 11
⌛ Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
⌛ Native Tests - Misc4 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/logging-panache

📦 integration-tests/logging-panache

✖ io.quarkus.logging.LoggingWithPanacheDevModeTest.testRepositoryIsReloaded line 41 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

@gsmet gsmet merged commit ebb6d0d into quarkusio:2.16 May 17, 2023
@scrocquesel
Copy link
Contributor Author

@gsmet Are you planning to release version 2.16.8? It would be very kind to have this fix available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scrocquesel @aloubyansky @gsmet