Support Dev Services for PostgreSQL database with images from Red Hat registry #44196
Comments
michalvavrik
added
area/hibernate-orm
|
/cc @geoand (devservices,openshift), @iocanel (openshift), @stuartwdouglas (devservices) |
|
cc @yrodiere |
michalvavrik
changed the title
I don't know, I get:
Could you paste the log you obtain when starting this container? |
outside of VPN. Also you can check this GH CI log (search for |
well I gave you steps to reproduce it, but I'll run it again report back, moment |
|
here you go: |
I forgot to mention @gsmet , I had to deal with it for our OpenShfit tests few weeks back, fix (or workaround?) was this: quarkus-qe/quarkus-test-framework#1305. And for PGDATA we do other |
doesn't look like these are publically available? |
|
Ah, sorry about that. I probably have some local config I forgot about. Interesting that GH CI can handle pulling images from RH registry though. |
|
@gsmet @maxandersen I am sorry I said that this image was publicly available. I was wrong. I reviewed few days ago PR of my colleague that insisted it was public and all checks I did seemed like he was right (like me and @mjurc could pull it as well, GH CI succeeded, ...). I am leaving this issue open because I think proposal makes sense and is testable considering GH CI can pull it without additional setup (for whatever reason). |
|
Well, I think you are trying to replace an official PostgreSQL image by something that doesn't respect the official PostgreSQL image contract. At least, that's what it looks like given it seems to ask for additional parameter. If you can determine what this image requires to boot properly and if you can paste the log output of the container start, we might be able to do something about it. But it's not certain. |
If my RHBQ application runs in OpenShift, I could use https://catalog.redhat.com/software/containers/rhel9/postgresql-16/657b03866783e1b1fb87e142 for development so that there are no hidden surprises when I use that image in OpenShift.
Yes, I can do that, I can probably open PR that shows how I can get it work and check that GH CI passes, but in the end I think it will be you who has to handle this. I'll try it later this week depending how my work schedule allows (which means we can check next week if I remember your plans :-) ). Let's wait till I check whether I am right or wrong. |
I understood your requirement. What I'm saying is that this image is not a 1-1 replacement for the official PostgreSQL image. It has different requirements. So we need to figure out what they are to see if we can make them work or not - while not breaking the support for the official image. Thus why I'm asking what are the additional parameters that are necessary to make it start and the log output to make sure the startup tests will work with it. Typically, we are testing: |
|
Sounds reasonable @gsmet , thanks. Yes, I know it is doable because I already have it working in QE TS, like you can see TC starting it when you do: But there is something in I am really glad you would be willing to fix that when I provide configuration requirements. |
|
My JIRA ticket just got closed and this is probably of little interest to community if downstream doesn't want it, so I'll close this. |
|
I think this is showing relevant issue and possible improvements we should look into. It is perfectly valid to explore if there is at least a way to have the user configure its way out of differences that various postgressql images has. |
|
Currently experimenting with the image redhat postgres 13:1-212 image which kind of works after I add the config below just to get the image to start correctly quarkus.datasource.devservices.image-name = rhel8/postgresql-13:1-212
quarkus.datasource.devservices.container-env."POSTGRESQL_USER" = ${quarkus.datasource.username:user}
quarkus.datasource.devservices.container-env."POSTGRESQL_PASSWORD" = ${quarkus.datasource.password:pass}
quarkus.datasource.devservices.container-env."POSTGRESQL_DATABASE" = ${quarkus.datasource.devservices.db-name:quarkus}
quarkus.datasource.devservices.command = /usr/bin/run-postgresql
quarkus.datasource.devservices.db-name = quarkusand but since the regex can’t find the correct log statement it fails after printing the after containers log outputs which are Doing a docker exec into the container with P.S. This also works for the latest rhel9 postgres 9.5-1734582033 which logs |
Don't know if this a quick solution, but if the generic database devservice would allow a user to define the start up regex themself with something like This might not be such a good idea in the long run though, since given my previous post I needed to set specific container-env for the red hat image since they are not the same as the dockerhub postgres image |
Description
I would like to develop my Quarkus application with database image I actually use later. I am using
registry.redhat.io/rhel9/postgresql-16:latest, but when I setquarkus.datasource.devservices.image-name=registry.redhat.io/rhel9/postgresql-16:latestthen database startup is never detected. This image is available after login and safe, I'd like to use it because it aligns with my OpenShift deployment where I use it as well. It seems that this image is also available in GH CI, therefore Quarkus should be able to test it with community setup only.Implementation ideas
No response
The text was updated successfully, but these errors were encountered: