Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resources should be found from the classpath instead in web dep locator #44126

Closed
ia3andy opened this issue Oct 28, 2024 · 1 comment · Fixed by #44128
Closed

Resources should be found from the classpath instead in web dep locator #44126

ia3andy opened this issue Oct 28, 2024 · 1 comment · Fixed by #44128
Assignees
@ia3andy
Milestone
3.15.3

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Oct 28, 2024

Currently, resources are found from the output directory which can be really fragile:
https://github.com/quarkusio/quarkus/blob/main/extensions/web-dependency-locator/deployment/src/main/java/io/quarkus/webdependency/locator/deployment/WebDependencyLocatorProcessor.java#L51

Instead we should use:
ClassPathUtils.consumeAsPaths(config.webRoot)
@ia3andy ia3andy changed the title Resources should be found from the classpath instead Resources should be found from the classpath instead in web dep locator Oct 28, 2024
@ia3andy ia3andy self-assigned this Oct 28, 2024
@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 28, 2024

I am working on this

@ia3andy ia3andy mentioned this issue Oct 28, 2024
Merged
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 28, 2024
@gsmet gsmet modified the milestones: 3.17 - main, 3.16.1 Oct 29, 2024
@gsmet gsmet modified the milestones: 3.16.1, 3.15.3 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ia3andy ia3andy

Labels
None yet
Projects
None yet
Milestone
3.15.3
Development

Successfully merging a pull request may close this issue.

Safer lookup and generate static resources for web dep locator ia3andy/quarkus
3 participants
@gsmet @ia3andy @geoand