Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OidcRestClientIT due to upstream bug #1586

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Dec 21, 2023

Summary

I bet with my luck quarkusio/quarkus#37788 will get merged anytime now, but our daily build has been failing for more than a week now and other testing is cancelled as this is failing, we need to run full test coverage. So I suggest to disable the test even though upstream PR can be merged in an hour or so.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from jedla97 December 21, 2023 19:48
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CI is green so merging

@jedla97 jedla97 merged commit b88f334 into quarkus-qe:main Dec 21, 2023
@michalvavrik michalvavrik deleted the feature/disable-oidc-client-test branch December 21, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants