Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Quarkus CLI tests #1164

Merged

Conversation

michalvavrik
Copy link
Member

Summary

  • move Quarkus CLI utils and framework-like code to this FW from TS
  • merge Quarkus CLI client tests in FW because there was unnecessary repetition
  • add test for listing extensions

Here is how changes in the Quarkus Test Suite are going to look: quarkus-qe/quarkus-test-suite@main...michalvavrik:quarkus-test-suite:feature/quarkus-cli-refactoring I didn't run special chars on Windows, but apart of that I tested all changes with TS (native, JVM).

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/quarkus-cli-refactoring branch from 49d35f1 to 97f0d1a Compare June 6, 2024 09:11
@michalvavrik michalvavrik merged commit abf0c71 into quarkus-qe:main Jun 6, 2024
1 check failed
@michalvavrik michalvavrik deleted the feature/quarkus-cli-refactoring branch June 6, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants