Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishing some TODOs and enable SureFireDebugIT on snapshot #1134

Merged
merged 5 commits into from
May 21, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented May 19, 2024

Summary

  1. Removing quarkus.package.type as 3.10 is out + change isNativePackageType method to isNativeEnabled as native is not defined by package type property.
  2. Updating consul image version to latest and moving it from class to pom. This removing showcase of image property defaulting to some image but the consul was not updated for some time. Maybe this should be just mention in docs.
  3. Enable SureFireDebugIT on snapshot
  4. Update TODO message

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member Author

jedla97 commented May 19, 2024

run tests

@jedla97
Copy link
Member Author

jedla97 commented May 20, 2024

run tests

@jedla97
Copy link
Member Author

jedla97 commented May 21, 2024

run tests

@jedla97 jedla97 requested a review from michalvavrik May 21, 2024 11:51
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants