Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable test as the issue is closed #1131

Merged
merged 1 commit into from
May 17, 2024
Merged

Enable test as the issue is closed #1131

merged 1 commit into from
May 17, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented May 15, 2024

Summary

Enable tests which were affected by quarkusio/quarkus#38018

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member Author

jedla97 commented May 15, 2024

run tests

@jedla97
Copy link
Member Author

jedla97 commented May 15, 2024

Please DO NOT MERGE yet looking into connection with ocp

@jedla97
Copy link
Member Author

jedla97 commented May 15, 2024

run tests

@jedla97
Copy link
Member Author

jedla97 commented May 16, 2024

run tests

@jedla97
Copy link
Member Author

jedla97 commented May 16, 2024

run tests

@jedla97 jedla97 requested a review from michalvavrik May 17, 2024 19:27
michalvavrik
michalvavrik approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for opening the upstream issue.

@michalvavrik michalvavrik merged commit d77d8f9 into quarkus-qe:main May 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedla97 @michalvavrik