Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote DEV mode relative path in POM file #1130

Conversation

michalvavrik
Copy link
Member

Summary

fixes: #800

The skip for the checkstyle was added here #798.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@QuarkusQE
Copy link
Contributor

Can one of the admins verify this patch?

@michalvavrik michalvavrik requested a review from rsvoboda May 14, 2024 23:47
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @michalvavrik, LGTM!

@rsvoboda rsvoboda merged commit f905b6e into quarkus-qe:main May 15, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/fix-remote-dev-mode-relative-path branch May 15, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust the parent location to point to the parent in the original workspace
3 participants