Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump quarkus to 3.2.11.Final in 1.3.z #1068

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Mar 20, 2024

Summary

Bump quarkus to 3.2.11

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from michalvavrik March 20, 2024 11:42
@mocenas
Copy link
Contributor Author

mocenas commented Mar 20, 2024

run tests

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I don't think that OpenShiftStrimziOperatorKafkaWithoutRegistryMessagingIT is related, but please double check before mering.

@mocenas
Copy link
Contributor Author

mocenas commented Mar 20, 2024

lgtm, I don't think that OpenShiftStrimziOperatorKafkaWithoutRegistryMessagingIT is related, but please double check before mering.

I'm not sure if it's related to bump, possibly yes. Problem is, than in our template, we have too old kafka instance (3.5.0) but related kafka operator supports only 3.6.0, 3.6.1 and 3.7.0.

I'm sending here a fix, to bump required kafka version to 3.7.0. As far as can tell from local testing, it should fix the issue.

@mocenas
Copy link
Contributor Author

mocenas commented Mar 20, 2024

run tests

@michalvavrik michalvavrik self-requested a review March 20, 2024 14:08
@mocenas
Copy link
Contributor Author

mocenas commented Mar 20, 2024

Fail in OpenShiftUsingExtensionAndServerlessFunqyKnEventsIT seems to be just fluke.

@michalvavrik michalvavrik merged commit e44d084 into quarkus-qe:1.3.z Mar 20, 2024
8 of 9 checks passed
@mocenas mocenas deleted the bump_1.3.z_3.2.11.Final branch March 21, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants