Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.4.2.Beta8 #1044

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Release 1.4.2.Beta8 #1044

merged 2 commits into from
Feb 14, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Feb 14, 2024

Summary

(Summarize the problem solved by this PR, and how to verify it manually)

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from fedinskiy February 14, 2024 10:19
fedinskiy
fedinskiy reviewed Feb 14, 2024
View reviewed changes
.github/project.yml Outdated
current-version: 1.4.1.Beta8
next-version: 1.4.0.Beta9
current-version: 1.4.2.Beta8
next-version: 1.4.3.Beta9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably do no want to rise both .z and BetaN parts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I kept the difference that was there previously.
I've changed it to remain on Beta8 in the next version.

fedinskiy
fedinskiy reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@mocenas mocenas requested a review from fedinskiy February 14, 2024 11:57
@mocenas mocenas merged commit 93757f2 into main Feb 14, 2024
7 checks passed
@mocenas mocenas deleted the release/1.4.2.Beta8 branch February 14, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedinskiy fedinskiy fedinskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mocenas @fedinskiy