Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a HelmChartBuildItem #400

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Jan 22, 2025

Resolves: #393

The pull request introduces a helm chart build item. This deals with ordering / timing issues that are currently possible when we have multiple tools generating resources.

At the moment the build item is created by parsing the content of the generated files.
Future PR can improve uppon it so that the build item is generated first.

@iocanel iocanel requested a review from a team as a code owner January 22, 2025 12:37
@iocanel
Copy link
Contributor Author

iocanel commented Jan 22, 2025

@Sgitario: can you please have a look at it?

Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks @iocanel !

@Sgitario Sgitario merged commit 88365e5 into quarkiverse:main Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a build item that contains the content of generated chart
2 participants