Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve double quotes with values.yaml contain data with spaces #317

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

Sgitario
Copy link
Contributor

Fixes #315

@gsmet
Copy link
Member

gsmet commented Feb 20, 2024

Maybe it's just me but I would be very surprised if Jackson was outputting invalid Yaml. This seems odd to me.

@Sgitario
Copy link
Contributor Author

Maybe it's just me but I would be very surprised if Jackson was outputting invalid Yaml. This seems odd to me.

No, the output from Jackson is syntactically correct, it's the Helm client that complains about it.

@Sgitario Sgitario merged commit 417e371 into main Feb 20, 2024
3 checks passed
@Sgitario Sgitario deleted the 315 branch February 20, 2024 13:50
@gsmet
Copy link
Member

gsmet commented Feb 20, 2024

Should it be reported to the helm client? Because I would expect it to be able to read standard YAML :).

@Sgitario
Copy link
Contributor Author

Should it be reported to the helm client? Because I would expect it to be able to read standard YAML :).

Yes, good point. I will check if this issue is already reported and will do if it does not. The Helm client has plenty of limitions, one that annoyed me the most is about parsing strings to integers (this was reported a very while ago).

@gsmet
Copy link
Member

gsmet commented Feb 20, 2024

Thanks @Sgitario , great work as always :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quotes in src/main/helm/values.yaml get arbitrarily dropped in target/heml/openshift/*/values.yaml
2 participants