Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Consider removing/modifying LetterWithSubscripts #335

Open
bryano opened this issue Feb 27, 2019 · 1 comment
Open

Consider removing/modifying LetterWithSubscripts #335

bryano opened this issue Feb 27, 2019 · 1 comment

Comments

@bryano
Copy link
Contributor

bryano commented Feb 27, 2019

The current implementation seems pretty hacky and brittle.

For one, LetterWithSubscripts('x', 1, 2) == LetterWithSubscripts('x_1_2') == LetterWithSubscripts('x', '1_2'). According to @Strilanc, this is necessary because of how poorly Sympy treats subclasses of sympy.Symbol.

One possible alternative replace the class entirely with a function letter_with_subscripts that returns a sympy.Symbol object directly with the right name. The function could set the letter and subscripts attributes of the object, but that might not play well with mypy.

@bryano
Copy link
Contributor Author

bryano commented Feb 27, 2019

If it's left as is, the inputs should at least be validated or parsed so that LetterWithSubscripts('x_1_2') either throws an error or evaluates to LetterWithSubscripts('x', 1, 2).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant