Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio docs point to non-existant file for midi information #4619

Closed
jetpacktuxedo opened this issue Dec 12, 2018 · 3 comments · Fixed by #4620
Closed

Audio docs point to non-existant file for midi information #4619

jetpacktuxedo opened this issue Dec 12, 2018 · 3 comments · Fixed by #4620

Comments

@jetpacktuxedo
Copy link
Contributor

https://docs.qmk.fm/#/feature_audio?id=midi-functionality points to quantum/keymap_midi.c which is not a thing that exists.

@noroadsleft
Copy link
Member

quantum/keymap_midi.c was removed in 65faab3. It seems to have been refactored into quantum/process_keycode/process_midi.c and quantum/process_keycode/process_midi.h, but I'm not nearly skilled enough in C to know if that's actually the case.

@drashna
Copy link
Member

drashna commented Dec 12, 2018

Yup, it was refactored.

Now.... do I add full documentation, or just update the line.

@jetpacktuxedo
Copy link
Contributor Author

I mean, if you're up to writing full docs then I'd definitely suggest doing that, but imo updating the line would close this issue while actually documenting the midi stuff would be a separate one.

@jetpacktuxedo jetpacktuxedo changed the title Audio docs point to non-existatnt file for midi information Audio docs point to non-existant file for midi information Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants