Skip to content

Commit d36f73a

Browse files
fauxparkfauxpark
authored
is31fl3737: driver naming cleanups (#21904)
1 parent 4a0badf commit d36f73a

File tree

8 files changed

+124
-95
lines changed

8 files changed

+124
-95
lines changed

‎docs/feature_rgb_matrix.md

+18-18
Original file line numberDiff line numberDiff line change
@@ -246,31 +246,31 @@ Configure the hardware via your `config.h`:
246246

247247
| Variable | Description | Default |
248248
|----------|-------------|---------|
249-
| `ISSI_TIMEOUT` | (Optional) How long to wait for i2c messages, in milliseconds | 100 |
250-
| `ISSI_PERSISTENCE` | (Optional) Retry failed messages this many times | 0 |
251-
| `ISSI_PWM_FREQUENCY` | (Optional) PWM Frequency Setting - IS31FL3737B only | 0 |
252-
| `ISSI_GLOBALCURRENT` | (Optional) Configuration for the Global Current Register | 0xFF |
253-
| `ISSI_SWPULLUP` | (Optional) Set the value of the SWx lines on-chip de-ghosting resistors | PUR_0R (Disabled) |
254-
| `ISSI_CSPULLUP` | (Optional) Set the value of the CSx lines on-chip de-ghosting resistors | PUR_0R (Disabled) |
255-
| `DRIVER_COUNT` | (Required) How many RGB driver IC's are present | |
249+
| `IS31FL3737_I2C_TIMEOUT` | (Optional) How long to wait for i2c messages, in milliseconds | 100 |
250+
| `IS31FL3737_I2C_PERSISTENCE` | (Optional) Retry failed messages this many times | 0 |
251+
| `IS31FL3737_PWM_FREQUENCY` | (Optional) PWM Frequency Setting - IS31FL3737B only | 0 |
252+
| `IS31FL3737_GLOBALCURRENT` | (Optional) Configuration for the Global Current Register | 0xFF |
253+
| `IS31FL3737_SWPULLUP` | (Optional) Set the value of the SWx lines on-chip de-ghosting resistors | PUR_0R (Disabled) |
254+
| `IS31FL3737_CSPULLUP` | (Optional) Set the value of the CSx lines on-chip de-ghosting resistors | PUR_0R (Disabled) |
255+
| `IS31FL3737_DRIVER_COUNT` | (Required) How many RGB driver IC's are present | |
256256
| `RGB_MATRIX_LED_COUNT` | (Required) How many RGB lights are present across all drivers | |
257257
| `DRIVER_ADDR_1` | (Required) Address for the first RGB driver | |
258258
| `DRIVER_ADDR_2` | (Optional) Address for the second RGB driver | |
259259
| `DRIVER_ADDR_3` | (Optional) Address for the third RGB driver | |
260260
| `DRIVER_ADDR_4` | (Optional) Address for the fourth RGB driver | |
261261

262-
The IS31FL3737 IC's have on-chip resistors that can be enabled to allow for de-ghosting of the RGB matrix. By default these resistors are not enabled (`ISSI_SWPULLUP`/`ISSI_CSPULLUP` are given the value of`PUR_0R`), the values that can be set to enable de-ghosting are as follows:
262+
The IS31FL3737 IC's have on-chip resistors that can be enabled to allow for de-ghosting of the RGB matrix. By default these resistors are not enabled (`IS31FL3737_SWPULLUP`/`IS31FL3737_CSPULLUP` are given the value of `IS31FL3737_PUR_0R`), the values that can be set to enable de-ghosting are as follows:
263263

264-
| `ISSI_SWPULLUP/ISSI_CSPULLUP` | Description |
264+
| `IS31FL3737_SWPULLUP/IS31FL3737_CSPULLUP` | Description |
265265
|----------------------|-------------|
266-
| `PUR_0R` | (default) Do not use the on-chip resistors/enable de-ghosting |
267-
| `PUR_05KR` | The 0.5k Ohm resistor used during blanking period (t_NOL) |
268-
| `PUR_1KR` | The 1k Ohm resistor used during blanking period (t_NOL) |
269-
| `PUR_2KR` | The 2k Ohm resistor used during blanking period (t_NOL) |
270-
| `PUR_4KR` | The 4k Ohm resistor used during blanking period (t_NOL) |
271-
| `PUR_8KR` | The 8k Ohm resistor during blanking period (t_NOL) |
272-
| `PUR_16KR` | The 16k Ohm resistor during blanking period (t_NOL) |
273-
| `PUR_32KR` | The 32k Ohm resistor used during blanking period (t_NOL) |
266+
| `IS31FL3737_PUR_0R` | (default) Do not use the on-chip resistors/enable de-ghosting |
267+
| `IS31FL3737_PUR_05KR` | The 0.5k Ohm resistor used during blanking period (t_NOL) |
268+
| `IS31FL3737_PUR_1KR` | The 1k Ohm resistor used during blanking period (t_NOL) |
269+
| `IS31FL3737_PUR_2KR` | The 2k Ohm resistor used during blanking period (t_NOL) |
270+
| `IS31FL3737_PUR_4KR` | The 4k Ohm resistor used during blanking period (t_NOL) |
271+
| `IS31FL3737_PUR_8KR` | The 8k Ohm resistor during blanking period (t_NOL) |
272+
| `IS31FL3737_PUR_16KR` | The 16k Ohm resistor during blanking period (t_NOL) |
273+
| `IS31FL3737_PUR_32KR` | The 32k Ohm resistor used during blanking period (t_NOL) |
274274

275275
Here is an example using 2 drivers.
276276

@@ -287,7 +287,7 @@ Here is an example using 2 drivers.
287287
#define DRIVER_ADDR_1 0b1010000
288288
#define DRIVER_ADDR_2 0b1010001
289289

290-
#define DRIVER_COUNT 2
290+
#define IS31FL3737_DRIVER_COUNT 2
291291
#define DRIVER_1_LED_TOTAL 30
292292
#define DRIVER_2_LED_TOTAL 36
293293
#define RGB_MATRIX_LED_COUNT (DRIVER_1_LED_TOTAL + DRIVER_2_LED_TOTAL)

‎drivers/led/issi/is31fl3737.c

+59-58
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
*/
1919

2020
#include "is31fl3737.h"
21+
#include <string.h>
2122
#include "i2c_master.h"
2223
#include "wait.h"
2324

@@ -31,46 +32,46 @@
3132
// ADDR1 represents A1:A0 of the 7-bit address.
3233
// ADDR2 represents A3:A2 of the 7-bit address.
3334
// The result is: 0b101(ADDR2)(ADDR1)
34-
#define ISSI_ADDR_DEFAULT 0x50
35-
36-
#define ISSI_COMMANDREGISTER 0xFD
37-
#define ISSI_COMMANDREGISTER_WRITELOCK 0xFE
38-
#define ISSI_INTERRUPTMASKREGISTER 0xF0
39-
#define ISSI_INTERRUPTSTATUSREGISTER 0xF1
40-
41-
#define ISSI_PAGE_LEDCONTROL 0x00 // PG0
42-
#define ISSI_PAGE_PWM 0x01 // PG1
43-
#define ISSI_PAGE_AUTOBREATH 0x02 // PG2
44-
#define ISSI_PAGE_FUNCTION 0x03 // PG3
45-
46-
#define ISSI_REG_CONFIGURATION 0x00 // PG3
47-
#define ISSI_REG_GLOBALCURRENT 0x01 // PG3
48-
#define ISSI_REG_RESET 0x11 // PG3
49-
#define ISSI_REG_SWPULLUP 0x0F // PG3
50-
#define ISSI_REG_CSPULLUP 0x10 // PG3
51-
52-
#ifndef ISSI_TIMEOUT
53-
# define ISSI_TIMEOUT 100
35+
#define IS31FL3737_I2C_ADDRESS_DEFAULT 0x50
36+
37+
#define IS31FL3737_COMMANDREGISTER 0xFD
38+
#define IS31FL3737_COMMANDREGISTER_WRITELOCK 0xFE
39+
#define IS31FL3737_INTERRUPTMASKREGISTER 0xF0
40+
#define IS31FL3737_INTERRUPTSTATUSREGISTER 0xF1
41+
42+
#define IS31FL3737_PAGE_LEDCONTROL 0x00 // PG0
43+
#define IS31FL3737_PAGE_PWM 0x01 // PG1
44+
#define IS31FL3737_PAGE_AUTOBREATH 0x02 // PG2
45+
#define IS31FL3737_PAGE_FUNCTION 0x03 // PG3
46+
47+
#define IS31FL3737_REG_CONFIGURATION 0x00 // PG3
48+
#define IS31FL3737_REG_GLOBALCURRENT 0x01 // PG3
49+
#define IS31FL3737_REG_RESET 0x11 // PG3
50+
#define IS31FL3737_REG_SWPULLUP 0x0F // PG3
51+
#define IS31FL3737_REG_CSPULLUP 0x10 // PG3
52+
53+
#ifndef IS31FL3737_I2C_TIMEOUT
54+
# define IS31FL3737_I2C_TIMEOUT 100
5455
#endif
5556

56-
#ifndef ISSI_PERSISTENCE
57-
# define ISSI_PERSISTENCE 0
57+
#ifndef IS31FL3737_I2C_PERSISTENCE
58+
# define IS31FL3737_I2C_PERSISTENCE 0
5859
#endif
5960

60-
#ifndef ISSI_PWM_FREQUENCY
61-
# define ISSI_PWM_FREQUENCY 0b000 // PFS - IS31FL3737B only
61+
#ifndef IS31FL3737_PWM_FREQUENCY
62+
# define IS31FL3737_PWM_FREQUENCY 0b000 // PFS - IS31FL3737B only
6263
#endif
6364

64-
#ifndef ISSI_SWPULLUP
65-
# define ISSI_SWPULLUP PUR_0R
65+
#ifndef IS31FL3737_SWPULLUP
66+
# define IS31FL3737_SWPULLUP IS31FL3737_PUR_0R
6667
#endif
6768

68-
#ifndef ISSI_CSPULLUP
69-
# define ISSI_CSPULLUP PUR_0R
69+
#ifndef IS31FL3737_CSPULLUP
70+
# define IS31FL3737_CSPULLUP IS31FL3737_PUR_0R
7071
#endif
7172

72-
#ifndef ISSI_GLOBALCURRENT
73-
# define ISSI_GLOBALCURRENT 0xFF
73+
#ifndef IS31FL3737_GLOBALCURRENT
74+
# define IS31FL3737_GLOBALCURRENT 0xFF
7475
#endif
7576

7677
// Transfer buffer for TWITransmitData()
@@ -83,22 +84,22 @@ uint8_t g_twi_transfer_buffer[20];
8384
// buffers and the transfers in is31fl3737_write_pwm_buffer() but it's
8485
// probably not worth the extra complexity.
8586

86-
uint8_t g_pwm_buffer[DRIVER_COUNT][192];
87-
bool g_pwm_buffer_update_required[DRIVER_COUNT] = {false};
87+
uint8_t g_pwm_buffer[IS31FL3737_DRIVER_COUNT][192];
88+
bool g_pwm_buffer_update_required[IS31FL3737_DRIVER_COUNT] = {false};
8889

89-
uint8_t g_led_control_registers[DRIVER_COUNT][24] = {0};
90-
bool g_led_control_registers_update_required[DRIVER_COUNT] = {false};
90+
uint8_t g_led_control_registers[IS31FL3737_DRIVER_COUNT][24] = {0};
91+
bool g_led_control_registers_update_required[IS31FL3737_DRIVER_COUNT] = {false};
9192

9293
void is31fl3737_write_register(uint8_t addr, uint8_t reg, uint8_t data) {
9394
g_twi_transfer_buffer[0] = reg;
9495
g_twi_transfer_buffer[1] = data;
9596

96-
#if ISSI_PERSISTENCE > 0
97-
for (uint8_t i = 0; i < ISSI_PERSISTENCE; i++) {
98-
if (i2c_transmit(addr << 1, g_twi_transfer_buffer, 2, ISSI_TIMEOUT) == 0) break;
97+
#if IS31FL3737_I2C_PERSISTENCE > 0
98+
for (uint8_t i = 0; i < IS31FL3737_I2C_PERSISTENCE; i++) {
99+
if (i2c_transmit(addr << 1, g_twi_transfer_buffer, 2, IS31FL3737_I2C_TIMEOUT) == 0) break;
99100
}
100101
#else
101-
i2c_transmit(addr << 1, g_twi_transfer_buffer, 2, ISSI_TIMEOUT);
102+
i2c_transmit(addr << 1, g_twi_transfer_buffer, 2, IS31FL3737_I2C_TIMEOUT);
102103
#endif
103104
}
104105

@@ -116,12 +117,12 @@ void is31fl3737_write_pwm_buffer(uint8_t addr, uint8_t *pwm_buffer) {
116117
// thus this sets registers 0x00-0x0F, 0x10-0x1F, etc. in one transfer
117118
memcpy(g_twi_transfer_buffer + 1, pwm_buffer + i, 16);
118119

119-
#if ISSI_PERSISTENCE > 0
120-
for (uint8_t i = 0; i < ISSI_PERSISTENCE; i++) {
121-
if (i2c_transmit(addr << 1, g_twi_transfer_buffer, 17, ISSI_TIMEOUT) == 0) break;
120+
#if IS31FL3737_I2C_PERSISTENCE > 0
121+
for (uint8_t i = 0; i < IS31FL3737_I2C_PERSISTENCE; i++) {
122+
if (i2c_transmit(addr << 1, g_twi_transfer_buffer, 17, IS31FL3737_I2C_TIMEOUT) == 0) break;
122123
}
123124
#else
124-
i2c_transmit(addr << 1, g_twi_transfer_buffer, 17, ISSI_TIMEOUT);
125+
i2c_transmit(addr << 1, g_twi_transfer_buffer, 17, IS31FL3737_I2C_TIMEOUT);
125126
#endif
126127
}
127128
}
@@ -133,39 +134,39 @@ void is31fl3737_init(uint8_t addr) {
133134
// then disable software shutdown.
134135

135136
// Unlock the command register.
136-
is31fl3737_write_register(addr, ISSI_COMMANDREGISTER_WRITELOCK, 0xC5);
137+
is31fl3737_write_register(addr, IS31FL3737_COMMANDREGISTER_WRITELOCK, 0xC5);
137138

138139
// Select PG0
139-
is31fl3737_write_register(addr, ISSI_COMMANDREGISTER, ISSI_PAGE_LEDCONTROL);
140+
is31fl3737_write_register(addr, IS31FL3737_COMMANDREGISTER, IS31FL3737_PAGE_LEDCONTROL);
140141
// Turn off all LEDs.
141142
for (int i = 0x00; i <= 0x17; i++) {
142143
is31fl3737_write_register(addr, i, 0x00);
143144
}
144145

145146
// Unlock the command register.
146-
is31fl3737_write_register(addr, ISSI_COMMANDREGISTER_WRITELOCK, 0xC5);
147+
is31fl3737_write_register(addr, IS31FL3737_COMMANDREGISTER_WRITELOCK, 0xC5);
147148

148149
// Select PG1
149-
is31fl3737_write_register(addr, ISSI_COMMANDREGISTER, ISSI_PAGE_PWM);
150+
is31fl3737_write_register(addr, IS31FL3737_COMMANDREGISTER, IS31FL3737_PAGE_PWM);
150151
// Set PWM on all LEDs to 0
151152
// No need to setup Breath registers to PWM as that is the default.
152153
for (int i = 0x00; i <= 0xBF; i++) {
153154
is31fl3737_write_register(addr, i, 0x00);
154155
}
155156

156157
// Unlock the command register.
157-
is31fl3737_write_register(addr, ISSI_COMMANDREGISTER_WRITELOCK, 0xC5);
158+
is31fl3737_write_register(addr, IS31FL3737_COMMANDREGISTER_WRITELOCK, 0xC5);
158159

159160
// Select PG3
160-
is31fl3737_write_register(addr, ISSI_COMMANDREGISTER, ISSI_PAGE_FUNCTION);
161+
is31fl3737_write_register(addr, IS31FL3737_COMMANDREGISTER, IS31FL3737_PAGE_FUNCTION);
161162
// Set de-ghost pull-up resistors (SWx)
162-
is31fl3737_write_register(addr, ISSI_REG_SWPULLUP, ISSI_SWPULLUP);
163+
is31fl3737_write_register(addr, IS31FL3737_REG_SWPULLUP, IS31FL3737_SWPULLUP);
163164
// Set de-ghost pull-down resistors (CSx)
164-
is31fl3737_write_register(addr, ISSI_REG_CSPULLUP, ISSI_CSPULLUP);
165+
is31fl3737_write_register(addr, IS31FL3737_REG_CSPULLUP, IS31FL3737_CSPULLUP);
165166
// Set global current to maximum.
166-
is31fl3737_write_register(addr, ISSI_REG_GLOBALCURRENT, ISSI_GLOBALCURRENT);
167+
is31fl3737_write_register(addr, IS31FL3737_REG_GLOBALCURRENT, IS31FL3737_GLOBALCURRENT);
167168
// Disable software shutdown.
168-
is31fl3737_write_register(addr, ISSI_REG_CONFIGURATION, ((ISSI_PWM_FREQUENCY & 0b111) << 3) | 0x01);
169+
is31fl3737_write_register(addr, IS31FL3737_REG_CONFIGURATION, ((IS31FL3737_PWM_FREQUENCY & 0b111) << 3) | 0x01);
169170

170171
// Wait 10ms to ensure the device has woken up.
171172
wait_ms(10);
@@ -225,22 +226,22 @@ void is31fl3737_set_led_control_register(uint8_t index, bool red, bool green, bo
225226
void is31fl3737_update_pwm_buffers(uint8_t addr, uint8_t index) {
226227
if (g_pwm_buffer_update_required[index]) {
227228
// Firstly we need to unlock the command register and select PG1
228-
is31fl3737_write_register(addr, ISSI_COMMANDREGISTER_WRITELOCK, 0xC5);
229-
is31fl3737_write_register(addr, ISSI_COMMANDREGISTER, ISSI_PAGE_PWM);
229+
is31fl3737_write_register(addr, IS31FL3737_COMMANDREGISTER_WRITELOCK, 0xC5);
230+
is31fl3737_write_register(addr, IS31FL3737_COMMANDREGISTER, IS31FL3737_PAGE_PWM);
230231

231232
is31fl3737_write_pwm_buffer(addr, g_pwm_buffer[index]);
233+
g_pwm_buffer_update_required[index] = false;
232234
}
233-
g_pwm_buffer_update_required[index] = false;
234235
}
235236

236237
void is31fl3737_update_led_control_registers(uint8_t addr, uint8_t index) {
237238
if (g_led_control_registers_update_required[index]) {
238239
// Firstly we need to unlock the command register and select PG0
239-
is31fl3737_write_register(addr, ISSI_COMMANDREGISTER_WRITELOCK, 0xC5);
240-
is31fl3737_write_register(addr, ISSI_COMMANDREGISTER, ISSI_PAGE_LEDCONTROL);
240+
is31fl3737_write_register(addr, IS31FL3737_COMMANDREGISTER_WRITELOCK, 0xC5);
241+
is31fl3737_write_register(addr, IS31FL3737_COMMANDREGISTER, IS31FL3737_PAGE_LEDCONTROL);
241242
for (int i = 0; i < 24; i++) {
242243
is31fl3737_write_register(addr, i, g_led_control_registers[index][i]);
243244
}
245+
g_led_control_registers_update_required[index] = false;
244246
}
245-
g_led_control_registers_update_required[index] = false;
246247
}

‎drivers/led/issi/is31fl3737.h

+41-9
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,41 @@
1919

2020
#pragma once
2121

22+
// ======== DEPRECATED DEFINES - DO NOT USE ========
23+
#ifdef DRIVER_COUNT
24+
# define IS31FL3737_DRIVER_COUNT DRIVER_COUNT
25+
#endif
26+
#ifdef ISSI_TIMEOUT
27+
# define IS31FL3737_I2C_TIMEOUT ISSI_TIMEOUT
28+
#endif
29+
#ifdef ISSI_PERSISTENCE
30+
# define IS31FL3737_I2C_PERSISTENCE ISSI_PERSISTENCE
31+
#endif
32+
#ifdef ISSI_PWM_FREQUENCY
33+
# define IS31FL3737_PWM_FREQUENCY ISSI_PWM_FREQUENCY
34+
#endif
35+
#ifdef ISSI_SWPULLUP
36+
# define IS31FL3737_SWPULLUP ISSI_SWPULLUP
37+
#endif
38+
#ifdef ISSI_CSPULLUP
39+
# define IS31FL3737_CSPULLUP ISSI_CSPULLUP
40+
#endif
41+
#ifdef ISSI_GLOBALCURRENT
42+
# define IS31FL3737_GLOBALCURRENT ISSI_GLOBALCURRENT
43+
#endif
44+
45+
#define PUR_0R IS31FL3737_PUR_0R
46+
#define PUR_05KR IS31FL3737_PUR_05KR
47+
#define PUR_1KR IS31FL3737_PUR_1KR
48+
#define PUR_2KR IS31FL3737_PUR_2KR
49+
#define PUR_4KR IS31FL3737_PUR_4KR
50+
#define PUR_8KR IS31FL3737_PUR_8KR
51+
#define PUR_16KR IS31FL3737_PUR_16KR
52+
#define PUR_32KR IS31FL3737_PUR_32KR
53+
// ========
54+
2255
#include <stdint.h>
2356
#include <stdbool.h>
24-
#include <string.h>
2557
#include "progmem.h"
2658

2759
typedef struct is31_led {
@@ -49,14 +81,14 @@ void is31fl3737_set_led_control_register(uint8_t index, bool red, bool green, bo
4981
void is31fl3737_update_pwm_buffers(uint8_t addr, uint8_t index);
5082
void is31fl3737_update_led_control_registers(uint8_t addr, uint8_t index);
5183

52-
#define PUR_0R 0x00 // No PUR resistor
53-
#define PUR_05KR 0x01 // 0.5k Ohm resistor in t_NOL
54-
#define PUR_1KR 0x02 // 1.0k Ohm resistor in t_NOL
55-
#define PUR_2KR 0x03 // 2.0k Ohm resistor in t_NOL
56-
#define PUR_4KR 0x04 // 4.0k Ohm resistor in t_NOL
57-
#define PUR_8KR 0x05 // 8.0k Ohm resistor in t_NOL
58-
#define PUR_16KR 0x06 // 16k Ohm resistor in t_NOL
59-
#define PUR_32KR 0x07 // 32k Ohm resistor in t_NOL
84+
#define IS31FL3737_PUR_0R 0x00 // No PUR resistor
85+
#define IS31FL3737_PUR_05KR 0x01 // 0.5k Ohm resistor in t_NOL
86+
#define IS31FL3737_PUR_1KR 0x02 // 1.0k Ohm resistor in t_NOL
87+
#define IS31FL3737_PUR_2KR 0x03 // 2.0k Ohm resistor in t_NOL
88+
#define IS31FL3737_PUR_4KR 0x04 // 4.0k Ohm resistor in t_NOL
89+
#define IS31FL3737_PUR_8KR 0x05 // 8.0k Ohm resistor in t_NOL
90+
#define IS31FL3737_PUR_16KR 0x06 // 16k Ohm resistor in t_NOL
91+
#define IS31FL3737_PUR_32KR 0x07 // 32k Ohm resistor in t_NOL
6092

6193
#define A_1 0x00
6294
#define A_2 0x01

‎keyboards/dztech/tofu/ii/v1/config.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
# define RGB_MATRIX_DEFAULT_MODE RGB_MATRIX_CYCLE_ALL
8282
# define DRIVER_ADDR_1 0b1010000
8383
# define DRIVER_ADDR_2 0b1011111
84-
# define DRIVER_COUNT 2
84+
# define IS31FL3737_DRIVER_COUNT 2
8585
# define DRIVER_1_LED_TOTAL 46
8686
# define DRIVER_2_LED_TOTAL 20
8787
# define RGB_MATRIX_LED_COUNT (DRIVER_1_LED_TOTAL + DRIVER_2_LED_TOTAL)

‎keyboards/dztech/tofu/jr/v1/config.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
# define RGB_MATRIX_DEFAULT_MODE RGB_MATRIX_CYCLE_ALL
8282
# define DRIVER_ADDR_1 0b1010000
8383
# define DRIVER_ADDR_2 0b1011111
84-
# define DRIVER_COUNT 2
84+
# define IS31FL3737_DRIVER_COUNT 2
8585
# define DRIVER_1_LED_TOTAL 48
8686
# define DRIVER_2_LED_TOTAL 20
8787
# define RGB_MATRIX_LED_COUNT (DRIVER_1_LED_TOTAL + DRIVER_2_LED_TOTAL)

‎keyboards/frooastboard/walnut/config.h

+2-6
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,8 @@
33

44
#pragma once
55

6-
#define ISSI_TIMEOUT 100
7-
#define ISSI_PERSISTENCE 0
8-
#define ISSI_PWM_FREQUENCY 0b010
9-
#define ISSI_SWPULLUP PUR_0R
10-
#define ISSI_CSPULLUP PUR_0R
11-
#define DRIVER_COUNT 1
6+
#define IS31FL3737_PWM_FREQUENCY 0b010
7+
#define IS31FL3737_DRIVER_COUNT 1
128
#define RGB_MATRIX_LED_COUNT 48
139
#define DRIVER_ADDR_1 0b1010000
1410

‎keyboards/mt/mt84/config.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828

2929

30-
#define DRIVER_COUNT 2
30+
#define IS31FL3737_DRIVER_COUNT 2
3131
#define DRIVER_1_LED_TOTAL 44
3232
#define DRIVER_2_LED_TOTAL 40
3333
#define RGB_MATRIX_LED_COUNT (DRIVER_1_LED_TOTAL + DRIVER_2_LED_TOTAL)

‎keyboards/planck/ez/config.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252

5353
#define DRIVER_ADDR_1 0b1010000
5454

55-
#define DRIVER_COUNT 1
55+
#define IS31FL3737_DRIVER_COUNT 1
5656
#define RGB_MATRIX_LED_COUNT 47
5757

5858
#define RGB_MATRIX_KEYPRESSES

0 commit comments

Comments
 (0)