Kitchen Sink merge #39
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-By: Mitch Anderson <[email protected]> Co-authored-By: William Dutton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last commit left by Mitch, due to the use of qh-design-system history, this commit is not in a valid state for nice merging. I have also noted that there is too many /?a={{ in the templates which is a squiz only lookup. It should be in the value being given (if it can) or via a squiz template lookup so it adds this instead of for everyone.
@pedroportella, I'll leave it in your good hands on correcting this pr when time permits as css/js that is is doing is a bit over my head at this time. (plus unsure if i've done the correct job of bringing commit d41af06 back to life