Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGDS-111 breadcrumbs component restructure #214

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

stvp-qld
Copy link
Member

@stvp-qld stvp-qld commented Jan 7, 2025

  • Reorganise breadcrumbs files to match new Vanilla component standard
  • Convert Breadcrumbs JS functions to a class
  • Add breadcrumbs to the global QGDS object (src/index.js)
  • Formatting updated to meet project standards
  • Exclude .reports folder from Git.... .reports contains stylelint warnings and errors and is only needed locally

@stvp-qld stvp-qld marked this pull request as ready for review January 7, 2025 01:30
@stvp-qld stvp-qld changed the title DRAFT: QGDS-111 breadcrumbs component restructure QGDS-111 breadcrumbs component restructure Jan 7, 2025
Copy link
Collaborator

@pedroportella pedroportella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stvp-qld stvp-qld merged commit 67944d0 into develop Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants