Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing gdal commands in processing #19619

Closed
qgib opened this issue Oct 4, 2014 · 15 comments
Closed

Allow editing gdal commands in processing #19619

qgib opened this issue Oct 4, 2014 · 15 comments
Labels
Feature Request Feedback Waiting on the submitter for answers Processing Relating to QGIS Processing framework or individual Processing algorithms

Comments

@qgib
Copy link
Contributor

qgib commented Oct 4, 2014

Author Name: Paolo Cavallini (@pcav)
Original Redmine Issue: 11323

Redmine category:processing/gdal


See the implementation in GDALTools itself. Thi, together with the next feature req, would allow to get rid of the duplication between GDALTools and Processing


Related issue(s): #22568 (relates), #23032 (duplicates), #28451 (duplicates)
Redmine related issue(s): 14600, 15090, 20631


@qgib
Copy link
Contributor Author

qgib commented Oct 4, 2014

Author Name: Giovanni Manghi (@gioman)


  • project_id was changed from 78 to 17
  • category_id removed 58

@qgib
Copy link
Contributor Author

qgib commented Oct 4, 2014

Author Name: Giovanni Manghi (@gioman)


  • category_id was configured as Processing/GDAL

@qgib
Copy link
Contributor Author

qgib commented Oct 4, 2014

Author Name: Giovanni Manghi (@gioman)


  • assigned_to_id was configured as Victor Olaya

@qgib
Copy link
Contributor Author

qgib commented Jan 11, 2016

Author Name: Alexander Bruy (@alexbruy)


We already have field with generated GDAL command, but if I'm not wrpng, it is not editable yet.


  • status_id was changed from Open to In Progress

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • easy_fix was configured as 0

@qgib
Copy link
Contributor Author

qgib commented Mar 7, 2018

Author Name: Paolo Cavallini (@pcav)


Still true in QGIS 3. Unsure whether this is still an issue, as commands should be editable in the Processing history, for all algs.


  • assigned_to_id removed Victor Olaya

@qgib
Copy link
Contributor Author

qgib commented May 6, 2018

Author Name: Nyall Dawson (@nyalldawson)


  • subject was changed from Add an echo of the command line to GDALTools algs to Allow editing gdal commands in processing

@qgib
Copy link
Contributor Author

qgib commented May 6, 2018

Author Name: Nyall Dawson (@nyalldawson)


I'd be inclined to close this as a "won't-fix". The command line is shown only as a shortcut for people developing batch files and for execution outside of QGIS. There's no real way to fit an editable command into the processing world.

Alternative options would be:

  1. A separate plugin allowing execution of gdal command line tools via a toolbar button. Users could then copy commands from processing windows and paste and edit using that plugin.

Or

  1. A new gdal algorithm with a single "command" parameter, allowing for pasting of a gdal command to execute.

@qgib
Copy link
Contributor Author

qgib commented May 6, 2018

Author Name: Nyall Dawson (@nyalldawson)


  • status_id was changed from In Progress to Feedback

@qgib
Copy link
Contributor Author

qgib commented May 6, 2018

Author Name: Paolo Cavallini (@pcav)


I understand well your point. Same thing applies to other backends (grass, saga).
However, good old GDALTools made this straightforward, and power users took advantage of this function extensively. I think that missing it is a regression, not a very good thing.
Perhaps a more general solution should be designed, i.e. the capability of re-running analyses editing the command string by hand.

@qgib
Copy link
Contributor Author

qgib commented May 6, 2018

Author Name: Nicolas Cadieux (@NicolasCadieux)


Nyall Dawson wrote:

I'd be inclined to close this as a "won't-fix". The command line is shown only as a shortcut for people developing batch files and for execution outside of QGIS. There's no real way to fit an editable command into the processing world.

Alternative options would be:

  1. A separate plugin allowing execution of gdal command line tools via a toolbar button. Users could then copy commands from processing windows and paste and edit using that plugin.

Or

  1. A new gdal algorithm with a single "command" parameter, allowing for pasting of a gdal command to execute.

Hi,

I can't figure out how to add a comment without modifying the comment. Perhaps the "cite" button is the only way... anyways, I agree with Paolo that this is a major setback as the old tool really permitted users to learn the gdal command lines. It also gave flexibility. I agree that a "other command" parameter would be one way to go. Still, it would be important to see the list of files being used (in the case of gdalbuiltvrt). Currently all we see is that the file list will be created in (buildvrtInputFiles.txt). This is important as the order of the files is important in this module. Sorry if I messed up your comment. I will only see if I did this correctly after I press the "send" button!

Nicolas

@qgib
Copy link
Contributor Author

qgib commented Nov 26, 2018

Author Name: Jürgen Fischer (@jef-n)


@qgib
Copy link
Contributor Author

qgib commented May 3, 2019

Author Name: Sfkeller - (Sfkeller -)


I'd like to support this feature request turning the output command text field of the dialog into an editable text field (referring to #29793).

My test case and goal is to call e.g. "gdal_grid" as follows:

gdal_grid -a nearest:radius1=1:radius2=1:nodata=-99 \
-txe 50 350 -tye 650 450 -outsize 3 2 -zfield z \
"grid in.gpkg" "grid out.tif"

The parameters "-txe 50 350 -tye 650 450 -outsize 3 2" are currently unreachable through the processing dialog (i.e. they are not layer output creation options). Think also about the -sql option.

@alexbruy
Copy link
Contributor

I'm +1 to what @nyalldawson said. Editing command line does not fit into Processing world.

@alexbruy
Copy link
Contributor

Passing additional command line parameters Implemented in c224a01. I think we can close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Feedback Waiting on the submitter for answers Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

No branches or pull requests

3 participants