From c9ce259a6c33f21aa6bd1f02296c34ea8dba96cb Mon Sep 17 00:00:00 2001 From: Ruslan Tushov Date: Tue, 17 Sep 2024 15:39:47 +0500 Subject: [PATCH] unbuffered subprocess (#2213) --- core/parachain/pvf/workers.cpp | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/core/parachain/pvf/workers.cpp b/core/parachain/pvf/workers.cpp index ec0ba616a1..facdf741b3 100644 --- a/core/parachain/pvf/workers.cpp +++ b/core/parachain/pvf/workers.cpp @@ -27,9 +27,11 @@ namespace kagome::parachain { struct ProcessAndPipes : std::enable_shared_from_this { AsyncPipe pipe_stdin; - boost::asio::buffered_write_stream writer; + // NOLINTNEXTLINE(cppcoreguidelines-avoid-const-or-ref-data-members) + AsyncPipe &writer; AsyncPipe pipe_stdout; - boost::asio::buffered_read_stream reader; + // NOLINTNEXTLINE(cppcoreguidelines-avoid-const-or-ref-data-members) + AsyncPipe &reader; boost::process::child process; std::shared_ptr writing = std::make_shared(); std::shared_ptr reading = std::make_shared(); @@ -66,13 +68,7 @@ namespace kagome::parachain { if (ec) { return cb(ec); } - self->writer.async_flush( - [cb](boost::system::error_code ec, size_t) mutable { - if (ec) { - return cb(ec); - } - cb(outcome::success()); - }); + cb(outcome::success()); }); }); }