Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get merged cells cost too much time than expected #1382

Closed
evanscat opened this issue Oct 28, 2022 · 2 comments
Closed

Get merged cells cost too much time than expected #1382

evanscat opened this issue Oct 28, 2022 · 2 comments

Comments

@evanscat
Copy link

Description

Steps to reproduce the issue:

  1. a excel documment has 10,000 merged cells
  2. open the doc and call the GetMergeCells function

Describe the results you received:
it cost almost a minute
Describe the results you expected:
cost about 1 second
Output of go version:

go version go1.18.4 darwin/amd64

Excelize version or commit ID:

v2.6.1

Environment details (OS, Microsoft Excel™ version, physical, etc.):
Darwin Kernel Version 22.1.0: Sun Oct
2 GHz 四核Intel Core i5
16 GB 3733 MHz LPDDR4X

@xuri
Copy link
Member

xuri commented Oct 28, 2022

Thanks for your issue. The cell value of the merged cell would be returned when you get the merged cells if you needn't get this value, removing the get cell value statements will speed up as your expected.

@xuri xuri closed this as completed Jul 3, 2023
@xuri
Copy link
Member

xuri commented Jul 3, 2023

The issues #1018 and #1448 was similar with this, the performance of the GetMergeCells function has been improvement by #1500, and this optimization has been released in the version 2.7.1. Please upgrade to the latest version. I've closed this issue, if you have any question, please let me know, and you can reopen this anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants