Skip to content
This repository was archived by the owner on Jul 2, 2021. It is now read-only.

Refactoring Improvements #5

Closed
jperl opened this issue Feb 28, 2020 · 0 comments · Fixed by #8
Closed

Refactoring Improvements #5

jperl opened this issue Feb 28, 2020 · 0 comments · Fixed by #8
Assignees
@flaurida
Labels
enhancement New feature or request

Comments

@jperl
Copy link
Member

jperl commented Feb 28, 2020 •
edited
Loading

Separate out logic into:

ScreencastFrameCollector

  • emit frames from screencast

VideoFrameBuilder

  • order frames based on correct FPS

VideoWriter

  • start and end ffmpeg

PageVideoCapture

  • tie everything together
@jperl jperl added the enhancement New feature or request label Feb 28, 2020
@jperl jperl mentioned this issue Feb 28, 2020
Merged
@jperl jperl changed the title Refactor out FrameSequencer Add FrameSequencer Feb 28, 2020
@jperl jperl changed the title Add FrameSequencer Refactoring Improvements Feb 28, 2020
@jperl jperl mentioned this issue Feb 28, 2020
Closed
@flaurida flaurida mentioned this issue Mar 2, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flaurida flaurida

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor qawolf/playwright-video
2 participants
@jperl @flaurida