Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No module named geotiepoints.modisinterpolator #852

Closed
AlysonR opened this issue Jul 10, 2019 · 9 comments
Closed

No module named geotiepoints.modisinterpolator #852

AlysonR opened this issue Jul 10, 2019 · 9 comments

Comments

@AlysonR
Copy link

AlysonR commented Jul 10, 2019

when running this with composite set as some true_color or true_color_crefl it throws an error
ImportError: No module named geotiepoints.modisinterpolator
If you made geotiepoints pip able I could fix this.
Code:

    #given a path, find all the two correct files within
files = get_modis_filenames(path)
#load the global scene using satpy
#expects filenames to be geoloc first, then radiance path
#filenames must be in specific format
global_scene = Scene(reader = 'modis_l1b', filenames = files)
#for future reference here are all available datasets
available_datasets = global_scene.available_dataset_names()
#want to create a cloudtop composite
#for future reference all available composites
available_composites = global_scene.available_composite_names()
print available_composites
#expects the composite to be in a list
global_scene.load([composite])
global_scene.show(composite)
return
@djhoese
Copy link
Member

djhoese commented Jul 10, 2019

This is likely due to those composites loading data from the modis_l1b reader that requires interpolation from 1km resolution to 500m or 250m resolution. That said, the package is installable from pip and conda (via conda-forge):

conda install -c conda-forge python-geotiepoints
pip install python-geotiepoints

@AlysonR
Copy link
Author

AlysonR commented Jul 10, 2019

It also requires ImportError: No module named pyorbital.astronomy
What should be pip installed to fix this? Is there a way to just have these installed with satpy to avoid these import errors?

@djhoese
Copy link
Member

djhoese commented Jul 10, 2019

This is from the pyorbital package which can also be pip installed and conda installed. These packages are installed as dependencies with conda because of how easy it is to install the binary packages from conda. With pip we tried to avoid installing dependencies that weren't needed since they aren't needed by every reader, or composite, or writer. We tried to do this by making it possible by using "extras" with pip:

pip install satpy[modis_l1b]

But this can't easily cover all cases (dependencies for a writer, dependencies for a particular composite, etc).

Perhaps we should add geotiepoints and pyorbital as hard requirements. @mraspaud @sfinkens Thoughts?

In summary: This is a known headache of Satpy due to how modular it is and how many various dependencies could be involved in one workflow. I'm open to ideas for how we could better handle this (easily install or document dependencies for a workflow without installing a ton of dependencies when they aren't needed).

@AlysonR AlysonR closed this as completed Jul 30, 2019
@sfinkens
Copy link
Member

sfinkens commented Aug 7, 2019

@djhoese @mraspaud Is it possible to add a composites extra to setup.py which installs common requirements for composites? Then you could do

pip install satpy[modis_l1b,composites]

Or are the workflows too diverse for that? Otherwise, adding geotiepoints and pyorbital as hard requirements doesn't hurt either in my opinion.

@mraspaud
Copy link
Member

mraspaud commented Aug 7, 2019

@sfinkens that would be fine by me.

@djhoese
Copy link
Member

djhoese commented Aug 7, 2019

How about pyorbital becomes a hard requirement? I don't think geotiepoints is used outside of the readers right now, right?

@mraspaud
Copy link
Member

mraspaud commented Aug 7, 2019

yes, I'm ok with this

@mraspaud
Copy link
Member

mraspaud commented Aug 7, 2019

yes geotiepoints is only for the readers atm

@sfinkens
Copy link
Member

sfinkens commented Aug 7, 2019

Me, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants