Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming of optional datasets in composite configs and compositors #160

Closed
pnuu opened this issue Jan 17, 2018 · 3 comments
Closed

Comments

@pnuu
Copy link
Member

pnuu commented Jan 17, 2018

Code Sample, a minimal, complete, and verifiable piece of code

# visir.yaml
  nir_reflectance:
    compositor: !!python/name:satpy.composites.NIRReflectance
    prerequisites:
    - 11
    optional_prerequisites:
    - solar_zenith_angle
    - 13.4
# composites/__init__.py
class NIRReflectance(CompositeBase):

    def __call__(self, projectables, optional_datasets=None, **info):
        pass

Problem description

For optional datasets the naming is different in the YAML configuration files for the compositors compared to the variables used in the compositors.

Versions of Python, package at hand and relevant dependencies

All SatPy versions.

@pnuu
Copy link
Member Author

pnuu commented Jan 17, 2018

My preference would be optional_datasets in both, I believe that would require less work and would be easier to write ;-)

@djhoese
Copy link
Member

djhoese commented Jan 17, 2018

I think we need to standardize all of this. prerequisites versus datasets versus projectables. projectables is our old naming before we started calling things datasets, so I think that can go. If the YAML uses datasets that gets a little confusing since it doesn't have the same meaning as prerequisite or maybe dependency.

@djhoese
Copy link
Member

djhoese commented May 30, 2018

Closing this as a duplicate or at least part of #161. We will standardize these names when that issue is resolved.

@djhoese djhoese closed this as completed May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants