Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a disable_dropout utility fn #2353

Closed
SalmanMohammadi opened this issue Feb 6, 2025 · 4 comments
Closed

Add a disable_dropout utility fn #2353

SalmanMohammadi opened this issue Feb 6, 2025 · 4 comments
Assignees
@Ankur-singh
Labels
better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs community help wanted We would love the community's help completing this issue good first issue Good for newcomers

Comments

@SalmanMohammadi
Copy link
Collaborator 

          This might be useful as a training utility, e.g. `disable_dropout(model)`

Originally posted by @ebsmothers in #2275 (comment)
@SalmanMohammadi SalmanMohammadi added community help wanted We would love the community's help completing this issue better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs good first issue Good for newcomers labels Feb 6, 2025
@Ankur-singh
Copy link
Contributor

Hi @SalmanMohammadi, I have some time this weekend. Can you please assign it to me?

@SalmanMohammadi
Copy link
Collaborator Author

Absolutely @Ankur-singh : )

@Ankur-singh
Copy link
Contributor

@SalmanMohammadi and @ebsmothers what should be ideal location for function?

In torchtune/training/ directory, there are dedicated files for each functionality. disable_dropout is quite generic but there is no generic utils.py file or something similar. Any suggestions?

@acisseJZhong
Copy link
Contributor

Hi @Ankur-singh you could create a model_util.py file under torchtune/training/ and put disable_dropout there. cc @ebsmothers if you have better place in mind.

@Ankur-singh Ankur-singh mentioned this issue Feb 11, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ankur-singh Ankur-singh

Labels
better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs community help wanted We would love the community's help completing this issue good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ankur-singh @SalmanMohammadi @acisseJZhong