Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement download subcommand, optional positional model name argument #234

Merged
merged 14 commits into from
Apr 19, 2024
Merged

Implement download subcommand, optional positional model name argument #234

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
07ae9c6
Implement download option
GregoryComer Apr 16, 2024
a8d145a
Add support for model aliases
GregoryComer Apr 17, 2024
73f1019
Support model name as a positional parameter
GregoryComer Apr 17, 2024
a28da17
Merge GenerateArgs changes
GregoryComer Apr 17, 2024
4c3250c
Run lint
GregoryComer Apr 17, 2024
64318e2
Revert chat subcommand/arg changes
GregoryComer Apr 17, 2024
f40cccc
Add mistral-7b-instruct alias, fix lints
GregoryComer Apr 17, 2024
79766dc
Add model config for known models
GregoryComer Apr 18, 2024
3dee14e
Move known model config to config/models.json
GregoryComer Apr 18, 2024
4e71dfa
Make model names case-insensitive
GregoryComer Apr 18, 2024
8b6fbb1
Move known model configuration from build/model.py to config/model_co…
GregoryComer Apr 18, 2024
08e80ac
Fix lints
GregoryComer Apr 18, 2024
5eab970
Fixing issues after rebasing
GregoryComer Apr 19, 2024
54543e0
Update README
GregoryComer Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,12 @@ class GeneratorArgs:
def from_args(cls, args): # -> GeneratorArgs:
return cls(
prompt=args.prompt,
<<<<<<< HEAD
encoded_prompt=None,
chat_mode=args.chat,
=======
chat_mode=hasattr(args, "subcommand") and args.subcommand == "chat",
>>>>>>> 0dc48b0 (Merge GenerateArgs changes)
gui_mode=args.gui,
num_samples=args.num_samples,
max_new_tokens=args.max_new_tokens,
Expand Down Expand Up @@ -546,8 +550,6 @@ def callback(x):


def main(args):
is_chat = args.subcommand == "chat"

# If a named model was provided and not downloaded, download it.
if args.model and not is_model_downloaded(args.model, args.model_directory):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should intercept this in a central place, like in cli() because all functions basically need to do the same? So we dupe it in a gazillion places?

download_and_convert(args.model, args.model_directory, args.hf_token)
Expand Down