Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import of sdpa_with_kv_cache to custom_ops #1470

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

Jack-Khuu
Copy link
Contributor

Picking up BC-breaking change from pytorch/executorch#6996 that was pulled in #1459

#1459 missed a callsite resulting in test failures found in #1463

Copy link

pytorch-bot bot commented Jan 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1470

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 7 Pending

As of commit 89abb8d with merge base 4c7183c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 22, 2025
@Jack-Khuu Jack-Khuu merged commit b2d8f2a into main Jan 22, 2025
56 of 62 checks passed
@Jack-Khuu Jack-Khuu deleted the Jack-Khuu-patch-34 branch January 24, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants