Detect unmatched skip begin/end commands #1309
Conversation
The updown processor should warn when skip begin/end are garbled
adjust nesting level on skip end
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1309
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7982fcd with merge base 791fe82 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Sorry for closing, I've assumed it's an old PR as it showed a lots of conflicts. Reopening... |
replacing llama3 with stories15 meant we got stories15.1. Fixing for `run-docs readme`
No worries. Sync'ed and added a fix for llama3 -> llama3.1 (not sure how this has been working, local runs created stories15.1 after substituting s/llama3/stories15/ |
|
@malfet please have a look at this test https://github.com/pytorch/torchchat/actions/runs/11375390708/job/31652543330?pr=1309 - it appears to be failing, yet is indicated as passing (independent of this PR) Ditto https://github.com/pytorch/torchchat/actions/runs/11375390717/job/31652547554?pr=1309 which is explicitly erroring out with |
warn about unmatched skip markup in docs run thru updown processor (processing test markup for markdown files)
cc: @swolchok