change in TRT-LLM loading mechanism and exposing aot_joint_export in _compiler.py #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: conversion
…ing in dynamo.compile
apbose
force-pushed
the
nccl_ops_trt_llm_installation
branch
from
57dbb3f to
3e38e87
Compare
narendasan
reviewed
Feb 25, 2025
| f"Ensure the path is correct and the library is compatible", | ||
| exc_info=e_os_error, | ||
| else: | ||
| py_version = f"cp{sys.version_info.major}{sys.version_info.minor}" |
There was a problem hiding this comment.
Why do we restrict to cp310 and cp312, It shouldnt matter if we are pulling the whl and unzipping ourselves
narendasan
reviewed
Feb 25, 2025
| ) | ||
| return False | ||
| download_url = base_url + file_name | ||
| cmd = ["wget", download_url] |
There was a problem hiding this comment.
What happens if wget is not installed?
narendasan
reviewed
Feb 25, 2025
| @@ -3,6 +3,8 @@ | |||
| import functools | |||
There was a problem hiding this comment.
Lets put this utility in some place that is more user accessible like torch_tensorrt.utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing in dynamo.compile
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: