fix: Split addmm nodes to not cast bias for FP32 accumulation and flux example fixes. #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: tests
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
narendasan
reviewed
Feb 19, 2025
| @@ -9,17 +9,41 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| def split_addmm_nodes(gm: torch.fx.GraphModule) -> torch.fx.GraphModule: | |||
There was a problem hiding this comment.
Dont we have a decomp for this?
There was a problem hiding this comment.
/ should this not just be a decomp?
There was a problem hiding this comment.
modified it to use torch decomposition now
narendasan
reviewed
Feb 19, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Consider also removing the converter registry, impl and unittest for |
github-actions
bot
added
component: conversion
github-actions
bot
removed
component: conversion
|
The failing tests have open github issues already. Merging this PR as the failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split addmm nodes to not cast bias for FP32 accumulation and flux example fixes.
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: