Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support aten.clamp.Tensor and update aten.clamp.default dynamo converters #2522

Merged
merged 3 commits into from
Dec 28, 2023
Merged

feat: support aten.clamp.Tensor and update aten.clamp.default dynamo converters #2522

merged 3 commits into from
Dec 28, 2023

Conversation

zewenli98
Copy link
Collaborator

Description

support aten.clamp.Tensor and update aten.clamp.default dynamo converters

Fixes #2517

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Dec 8, 2023
@github-actions github-actions bot requested a review from peri044 December 8, 2023 01:09
@zewenli98 zewenli98 force-pushed the clamp_dynamo_converter branch from b722239 to de04072 Compare December 11, 2023 23:42
@zewenli98 zewenli98 requested a review from gs-olive December 12, 2023 01:47
@zewenli98 zewenli98 self-assigned this Dec 13, 2023
gs-olive
gs-olive reviewed Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good - it seems that a few of the test_clip converter tests are failing, however

@zewenli98 zewenli98 requested a review from gs-olive December 18, 2023 23:57
gs-olive
gs-olive approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zewenli98 zewenli98 merged commit 088900d into pytorch:main Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gs-olive gs-olive gs-olive approved these changes

@peri044 peri044 Awaiting requested review from peri044

@bowang007 bowang007 Awaiting requested review from bowang007

@apbose apbose Awaiting requested review from apbose

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aten.clamp.Tensor
3 participants
@zewenli98 @gs-olive @facebook-github-bot