From b628a3f1626689ec58a875c67651754b0fff89e3 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Mon, 11 Sep 2023 15:20:28 +0200 Subject: [PATCH 1/3] [redis] Don't recommend uninstalling types-redis Cf. #10592 --- stubs/redis/METADATA.toml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/stubs/redis/METADATA.toml b/stubs/redis/METADATA.toml index 17514301906a..6127eec8aaf9 100644 --- a/stubs/redis/METADATA.toml +++ b/stubs/redis/METADATA.toml @@ -3,7 +3,10 @@ upstream_repository = "https://github.com/redis/redis-py" # Requires a version of cryptography with a `py.typed` file requires = ["cryptography>=35.0.0", "types-pyOpenSSL"] partial_stub = true -obsolete_since = "5.0.0" # Released on 2023-08-15 +# While upstream added a py.typed file, the upstream annotations are rather +# incomplete. By using "obsolete_since" we recommend deinstalling this +# package, which isn't the best idea at the moment. +# obsolete_since = "5.0.0" # Released on 2023-08-15 [tool.stubtest] ignore_missing_stub = true From fea6364840d78bdb4577f494bdb09836a265f643 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Mon, 11 Sep 2023 15:53:13 +0200 Subject: [PATCH 2/3] Add an extra_description --- stubs/redis/METADATA.toml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/stubs/redis/METADATA.toml b/stubs/redis/METADATA.toml index 6127eec8aaf9..bd6117f001ed 100644 --- a/stubs/redis/METADATA.toml +++ b/stubs/redis/METADATA.toml @@ -7,6 +7,11 @@ partial_stub = true # incomplete. By using "obsolete_since" we recommend deinstalling this # package, which isn't the best idea at the moment. # obsolete_since = "5.0.0" # Released on 2023-08-15 +extra_description = """\ + Redis-py 5.0.0 added a py.typed file, but the annotations are fairly \ + incomplete, which is why the typeshed maintainers recommend to continue \ + using `types-redis` for the time being.\ + """ [tool.stubtest] ignore_missing_stub = true From 0be916b94baf65cd486548541393e07771c34f26 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Mon, 11 Sep 2023 16:58:25 +0200 Subject: [PATCH 3/3] Update stubs/redis/METADATA.toml Co-authored-by: Alex Waygood --- stubs/redis/METADATA.toml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/stubs/redis/METADATA.toml b/stubs/redis/METADATA.toml index bd6117f001ed..84f3ce183de3 100644 --- a/stubs/redis/METADATA.toml +++ b/stubs/redis/METADATA.toml @@ -8,9 +8,9 @@ partial_stub = true # package, which isn't the best idea at the moment. # obsolete_since = "5.0.0" # Released on 2023-08-15 extra_description = """\ - Redis-py 5.0.0 added a py.typed file, but the annotations are fairly \ - incomplete, which is why the typeshed maintainers recommend to continue \ - using `types-redis` for the time being.\ + Note: Redis-py 5.0.0 added a py.typed file, but the inline annotations \ + are incomplete. Continuing to use `types-redis` for the time being may \ + lead to superior results.\ """ [tool.stubtest]