Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A change of wording in PEP 654 - ExceptionGroups and except* #94

Closed
iritkatriel opened this issue Dec 22, 2021 · 3 comments
Closed

A change of wording in PEP 654 - ExceptionGroups and except* #94

iritkatriel opened this issue Dec 22, 2021 · 3 comments

Comments

@iritkatriel
Copy link
Member

Following a review of the PEP-654 documentation, we would like to make a change in the wording of the PEP to clarify that the factory function that automatically selects between ExceptionGroup and BaseExceptionGroup is in fact the BaseExceptionGroup constructor. Please see the proposed change here: python/peps#2203

@gvanrossum @1st1

@warsaw
Copy link
Member

warsaw commented Dec 24, 2021

This was discussed over in python/cpython#30158

I mentioned that there was a slight difference between the wording of the PEP, which at least to me implied a separate factory function, and the documentation in the above PR. The discussions over there made it clear that the intention of the API was for the wording in the docs, but as the PEP was what was approved by the 2021 SC, I felt it was necessary for approval from the 2022 SC.

@Yhg1s
Copy link
Member

Yhg1s commented Dec 24, 2021

I've added it to the SC agenda.

@Yhg1s
Copy link
Member

Yhg1s commented Dec 27, 2021

The SC approves the wording change. (I've left a comment in the PR as well.)

@Yhg1s Yhg1s closed this as completed Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants