Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code to use fewer circular imports #93

Closed
JukkaL opened this issue Feb 1, 2013 · 4 comments
Closed

Refactor code to use fewer circular imports #93

JukkaL opened this issue Feb 1, 2013 · 4 comments
Labels
priority-1-normal refactoring Changing mypy's internals

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Feb 1, 2013 •
edited
Loading

The implementation uses circular imports more than is necessary.

Remove any circular imports that don't increase the readability/maintainability of the code.
@JukkaL JukkaL mentioned this issue Feb 1, 2013
Closed
@JukkaL
Copy link
Collaborator Author

JukkaL commented Feb 1, 2013

The module strconv is also associated with nodes.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Feb 1, 2013

I have removed these circular dependencies (not pushed yet):

  • messages -> checker
  • cgen -> build

@JukkaL
Copy link
Collaborator Author

JukkaL commented Feb 1, 2013

Also had to move checker.BasicTypes to mtypes. This removed many circular dependencies (not pushed yet).

@JukkaL
Copy link
Collaborator Author

JukkaL commented Feb 1, 2013

Now the changes I mentioned in the above 2 comments are available at the public repo.

@ilevkivskyi ilevkivskyi mentioned this issue Aug 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-1-normal refactoring Changing mypy's internals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JukkaL