Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that prevents increasing import cycles in the mypy implementation #7407

Open
JukkaL opened this issue Aug 29, 2019 · 1 comment
Open
Labels
priority-1-normal topic-developer Issues relevant to mypy developers topic-tests

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Aug 29, 2019

It's easy to accidentally introduce new modules in import cycles, which can make the structure of the codebase worse and slow down incremental builds. Add a test that checks that this does not happen.

See #7397 for context. Here is one idea from that PR:

We could perhaps run another incremental build after self check in verbose mode and assert that the largest import cycle is below some size limit by parsing the verbose output. Alternatively, we could modify verbose mode to write more details about SCCs in incremental mode and make more specific assertions, such as requiring that the nodes, typeops and checker cycles are disjoint.

@JukkaL JukkaL added priority-1-normal topic-developer Issues relevant to mypy developers labels Aug 29, 2019
@JukkaL
Copy link
Collaborator Author

JukkaL commented Aug 29, 2019

cc @msullivan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-1-normal topic-developer Issues relevant to mypy developers topic-tests
Projects
None yet
Development

No branches or pull requests

2 participants