Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building abi3 wheels #6852

Closed
erikjohnston opened this issue Oct 20, 2022 · 3 comments
Closed

Support building abi3 wheels #6852

erikjohnston opened this issue Oct 20, 2022 · 3 comments
Labels
status/duplicate Duplicate issues

Comments

@erikjohnston
Copy link

When building wheels for a project that has a build script, it would be very useful to be able to tag the wheels as abi3 compatible (assuming the build script outputs abi3 compatible libs).

We (Synapse) use a build script and setuptools_rust to allow us to use Rust code. In CI we use cibuildwheel to build wheels for various platforms and architectures, which can take a significant amount of time. Having to build a wheel for each cpython version unnecessarily is a significant chunk of that time.

I'm not familiar with how this is meant to work across different build systems, but as a first step it would be useful to have some way of forcing poetry to output the wheel with an abi3 tag. I think the relevant line we decide on the tag for the wheel is here.

@erikjohnston erikjohnston added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Oct 20, 2022
@neersighted
Copy link
Member

Duplicate #2051, unless I am mistaken; you want control over tags that are applied, which that issue should cover.

@neersighted neersighted added status/duplicate Duplicate issues and removed kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Oct 20, 2022
@neersighted neersighted closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2022
@erikjohnston
Copy link
Author

Ah sorry, I was looking for ABI3 specifically. Thanks, that does look like exactly what we want!

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/duplicate Duplicate issues
Projects
None yet
Development

No branches or pull requests

2 participants