Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit fails when pyproject.toml is in subdirectory #6259

Closed
2 of 3 tasks
wgiddens opened this issue Aug 29, 2022 · 2 comments
Closed
2 of 3 tasks

pre-commit fails when pyproject.toml is in subdirectory #6259

wgiddens opened this issue Aug 29, 2022 · 2 comments
Labels
kind/feature Feature requests/implementations

Comments

@wgiddens
Copy link

wgiddens commented Aug 29, 2022

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • Poetry version: 1.2.0-rc2

Issue

We are setting up the new pre-commit checks for our project. Our Python source code lives in a subfolder inside the main repo. The full path to pyproject.toml is <repo>/backend/src/pyproject.toml. The poetry checks fail because they can't find pyproject.toml in the root directory.

The pre-commit project does not support changing the working directory for hooks and will not add support. See pre-commit/pre-commit#1110 (comment)

pre-commit hooks can be configured to pass a matching filename argument, but poetry does not have a way to operate on anything but the current working directory.

@wgiddens wgiddens added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Aug 29, 2022
@finswimmer finswimmer added kind/feature Feature requests/implementations and removed kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Aug 29, 2022
@finswimmer
Copy link
Member

Hey @wgiddens,

I'm closing this as a specialized duplicate of #2179.

fin swimmer

@finswimmer finswimmer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2022
Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

2 participants