Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrading says it's updating #1394

Closed
2 of 3 tasks
im-n1 opened this issue Sep 20, 2019 · 5 comments · Fixed by #8176
Closed
2 of 3 tasks

Downgrading says it's updating #1394

im-n1 opened this issue Sep 20, 2019 · 5 comments · Fixed by #8176
Assignees
Labels
area/installer Related to the dependency installer kind/feature Feature requests/implementations

Comments

@im-n1
Copy link

im-n1 commented Sep 20, 2019

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

When I downgrade version Poetry says I'm "updating". Maybe "downdating" or even "downgrading" would be more appropriate.

  - Updating django (2.2.5 -> 2.1.12)
@kasteph kasteph added kind/feature Feature requests/implementations area/installer Related to the dependency installer and removed area/installer Related to the dependency installer labels Sep 23, 2019
@stale
Copy link

stale bot commented Nov 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 22, 2019
@im-n1
Copy link
Author

im-n1 commented Nov 24, 2019

No activity != problem solved

@abn
Copy link
Member

abn commented May 25, 2022

We should improve the operations to indicate that the package is being downgraded. This can potentially be done when the update operation is being logged and the target version is lower.

def __str__(self) -> str:
init_version = self.format_version(self.initial_package)
target_version = self.format_version(self.target_package)
return (
f"Updating {self.initial_package.pretty_name} ({init_version}) "
f"to {self.target_package.pretty_name} ({target_version})"
)

@gsemet
Copy link

gsemet commented May 25, 2022

Rewording + color should be enough.

Downgrading django (2.2.5 -> 2.1.12)

(in yellow for instance)

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/installer Related to the dependency installer kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants