Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export fails to include hashes of some requirements #90

Closed
shai4lt opened this issue Jul 13, 2022 · 6 comments
Closed

export fails to include hashes of some requirements #90

shai4lt opened this issue Jul 13, 2022 · 6 comments

Comments

@shai4lt
Copy link

shai4lt commented Jul 13, 2022

I created an empty project, ran poetry add s3fs, and export created a broken file.
https://gist.github.com/shai4lt/c5306a9c2221203c7368532c6951814a

(I should probably note that, having looked now, the packages missing hashes seem to miss them already in the lock file, so maybe export is not the culprit -- but export is where it causes issues.

poetry 1.2.0b2 with the export plugin (AFAICT poetry 1.1.13 and 1.1.14 behave the same)

@dimbleby
Copy link
Contributor

as you correctly note, this is a problem with poetry and not with this plugin, so the issue is in the wrong repository

But anyway, it's fixed in 1.1.14 and 1.2.0b3. You may need to clear your cache to prove the point.

Please close

@mkuijn-cb
Copy link

I can reproduce the described result with 1.1.14. I also get a requirements.txt that has packages missing hashes, albeit a different set of packages.

@dimbleby
Copy link
Contributor

This is python-poetry/poetry#5970, and the entire point of the 1.1.14 release was to pick up the fix.

Clear your cache, try again, close this out.

@mkuijn-cb
Copy link

I'm sorry, but this happens in a Docker container where there is no cache. I'll post a minimum (non)working example in a bit.

@shai4lt
Copy link
Author

shai4lt commented Jul 17, 2022

I can confirm that after clearing the cache and using poetry 1.1.14 to both lock and export, the resulting lock files has hashes, and so does the exported requirements.txt file; and further, installing from this requirements.txt file works.

@mkuijn-cb I'm guessing your case is somehow different, and if so deserves its own issue.

@shai4lt shai4lt closed this as completed Jul 17, 2022
@mkuijn-cb
Copy link

@shai4lt thank you for your comment, it brought clarity to the issue. I had neglected to rm the lock file, now it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants