Add and_ converter #618
Add and_ converter #618
Conversation
NI1993
force-pushed
the
feature/and_converter
branch
from
7b1403b to
36eef7e
Compare
src/attr/converters.py
Outdated
| :param converters: Arbitrary number of converters. | ||
| :type converters: callables | ||
|
|
||
| .. versionadded:: ??? |
There was a problem hiding this comment.
How can one tell the versionadded?
There was a problem hiding this comment.
It's in attr.__init__ without the .dev0 suffix.
|
Lint error: tests/test_converters.py:13:1: F401 'attr.s' imported but unused |
|
No tests for the |
|
Looking at the code, I find the name |
Thanks, removed it |
Certainly! |
I'm not sure how to test it : |
src/attr/converters.py
Outdated
| :param converters: Arbitrary number of converters. | ||
| :type converters: callables | ||
|
|
||
| .. versionadded:: ??? |
There was a problem hiding this comment.
It's in attr.__init__ without the .dev0 suffix.
Well I did, but it was mentioned that I missed testing the nested function + the codecov check failed so I just wondering how can I pass it |
NI1993
force-pushed
the
feature/and_converter
branch
from
4857681 to
71b52a1
Compare
|
@hynek it seems I still miss some.. |
|
Looks like either out-of-date branch or another codecov glitch. I think we're done here, thank you for your patience! |
|
@hynek Many thanks! |
* Add and_ converter * update _make * Refactored code according to review * fixed some linting errors * minor refactor * fixed CR comments * fixed CR comment #2 Co-authored-by: Hynek Schlawack <[email protected]>
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
.pyi).tests/typing_example.py.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives..rstfiles is written using semantic newlines.changelog.d.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!