-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent ordering of embedded files #171
Comments
Yeah that makes sense to me. Reproducible builds are good. |
Do you want me to provide a PR? |
Yeah, that would be great |
Done. |
Released in v6.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, as far as I can tell, and as reported in an issue in one of my projects, the ordering of the files in the built binary is undefined, since
rust-embed
uses WalkDir under the hood, which outputs files in undefined order unless thesort_by
function is used.Functionally, this doesn't matter, but it does pose issues for projects (and OSes and build processes) aiming or desiring reproducible builds.
As far as I can tell, this should be a pretty painless change, and backward compatible since the original order was always undefined.
I can try and craft a PR if it could help (and if this is wanted).
The text was updated successfully, but these errors were encountered: