Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content originating from JavaScript not marked for translation #7955

Closed
nlhkabu opened this issue May 15, 2020 · 2 comments
Closed

Content originating from JavaScript not marked for translation #7955

nlhkabu opened this issue May 15, 2020 · 2 comments
Labels
i18n Internationalization javascript requires change to JavaScript files translation Issues relating to PyPI translations

Comments

@nlhkabu
Copy link
Contributor

nlhkabu commented May 15, 2020

We have some content that is generated from JS. It is not currently marked for translation.

  • Copy tooltip
  • Time that has been humanized, e.g. "2 hours ago"
  • Password strength error messages
  • Password matching messages

There are probably more. We need to go through the JS source to identify these.
@nlhkabu nlhkabu added javascript requires change to JavaScript files i18n Internationalization translation Issues relating to PyPI translations labels May 15, 2020
@nlhkabu nlhkabu mentioned this issue May 15, 2020
Merged
3 tasks
@cofiem cofiem mentioned this issue Mar 17, 2024
Merged
@cofiem
Copy link
Contributor

cofiem commented Jan 17, 2025

The copy tooltip, timeago, and password match strings are addressed by merging #15612 The password strength phrases are tricky to translate due to being mixed with zxcvbn output.

@miketheman
Copy link
Member

Same as #6673 (comment) - we can explore zxcvbn separately if needed, but generally strings in warehouse' JS files are now localizable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i18n Internationalization javascript requires change to JavaScript files translation Issues relating to PyPI translations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cofiem @miketheman @nlhkabu