Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate if typing_extensions is still needed as a vendored dependency for pkg_resources #4324

Closed
abravalheri opened this issue Apr 22, 2024 · 2 comments · Fixed by #4347

Comments

@abravalheri
Copy link
Contributor

This (typing_extensions) was not listed. The vendored.txt file says the following:

# required for platformdirs on Python < 3.8
typing_extensions==4.4.0

But now we removed support to Python < 3.8, so I guess we can remove this vendored dependency?

Originally posted by @abravalheri in #4320 (comment)

@Avasam
Copy link
Contributor

Avasam commented Apr 25, 2024

I'd be surprised if we can't just hide whatever usage of typing_extensions behind TYPE_CHECKING checks and from __future__ import annotations.

@Avasam
Copy link
Contributor

Avasam commented Jul 23, 2024

On setuptools' side, jaraco.text is causing a chain of dependencies: inflect --> typeguard --> typing_extensions. These can all be removed with jaraco/jaraco.text#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants