From d901698dc01e18b4ebdb04e9a65df98883f7108b Mon Sep 17 00:00:00 2001 From: "Jason R. Coombs" Date: Tue, 3 Sep 2024 09:11:37 -0400 Subject: [PATCH] Add test capturing missed expectation. Ref #4615 --- setuptools/tests/test_sdist.py | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/setuptools/tests/test_sdist.py b/setuptools/tests/test_sdist.py index f628f3eb4a..d0db9c8d6f 100644 --- a/setuptools/tests/test_sdist.py +++ b/setuptools/tests/test_sdist.py @@ -4,6 +4,7 @@ import io import logging import os +import pathlib import sys import tarfile import tempfile @@ -822,6 +823,21 @@ def get_source_files(self): manifest = cmd.filelist.files assert '.myfile~' in manifest + @pytest.mark.xfail(reason="4615") + def test_build_base_pathlib(self, source_dir): + """ + Ensure if build_base is a pathlib.Path, the build still succeeds. + """ + dist = Distribution({ + **SETUP_ATTRS, + "script_name": "setup.py", + "options": {"build": {"build_base": pathlib.Path('build')}}, + }) + cmd = sdist(dist) + cmd.ensure_finalized() + with quiet(): + cmd.run() + def test_default_revctrl(): """